CodeHawks Escrow Contract - Competition Details

Summary

Unchecked call to the safeTransferFrom function in the newEscrow function.

Vulnerability Details

The safeTransferFrom function in the newEscrow function is not checked. This means that if the safe transfer from function fails, the newEscrow function will continue to execute. This could lead to unexpected behaviour, such as the escrow contract being created with an empty or incorrect balance.

Impact

The unchecked call to the safeTransferFrom function in the newEscrow function could lead to unexpected behaviour, such as the escrow contract being created with an empty or incorrect balance.

Tools Used

Slither, Remix

Recommendations

To fix the unchecked call to the safeTransferFrom function, the newEscrow function should be updated to check the return value of the safeTransferFrom function.