40,000 USDC
View results
Submission Details
Severity: gas

Difference in data type on input paratemers

Summary

Bytes32 and uint discrepancy

Vulnerability Details

In EscrowFactory.newEscrow() the salt is passed as bytes32 and then in the sub call to computeEscrowAddress() it is passed as uint

Impact

The contract compiles , so I guess by making the salt of one data type in both newEscrow() and computeEscrowAddress() we can save gas avoiding one data type conversion

Tools Used

Manual Review

Recommendations

Make the salt of one data type in both newEscrow() and computeEscrowAddress()

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.