CodeHawks Escrow Contract - Competition Details

Summary

Unchecked call to the safeTransfer function in the resolveDispute function.

Vulnerability Details

The safeTransfer function return value in the resolveDispute function is not checked. This means that if the safeTransfer function fails, the resolveDispute function will continue to execute. This could lead to unexpected behaviour, such as the arbiter not receiving their fee.

Impact

Medium impact where the arbiter may not receive their fee or the buyer lose out on the disputed amount.

Tools Used

Remix, Slither

Recommendations

To fix the unchecked call to the safeTransfer function, the resolveDispute function should be updated to check the return value of the safeTransfer function.