40,000 USDC
View results
Submission Details
Severity: medium
Valid

Funds will be locked if buyer or seller get into an accident and there’s no arbiter set because both seller and buyer trust each other

The contract allows for address(0) arbiter

https://github.com/Cyfrin/2023-07-escrow/blob/main/src/Escrow.sol#L49

However, in case of an accident happening to buyer or seller the funds will be locked with no way to recover.

https://github.com/Cyfrin/2023-07-escrow/blob/main/src/Escrow.sol#L103

Mitigation:

Always set a valid arbiter

Implement a new role which can set an arbiter/transfer funds

Implement a claim with a deadline. If no challenge before deadline transfer the funds to the claimer.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.