Submission Details
Severity:
The nonReentrant modifier should occur before all other modifiers
Summary
The nonReentrant modifier in line 109. should be place first if there are more than one modifiers.
Vulnerability Details
It is best practice to use it first to prevent reentry in other modifiers. The following is in ln 109.
function resolveDispute(uint256 buyerAward) external onlyArbiter nonReentrant inState(State.Disputed)
Impact
If there is complex logic in other modifiers, they will not be protected against reentry
Tools Used
Manual review
Recommendations
In line 109, this can be used
function resolveDispute(uint256 buyerAward) external nonReentrant onlyArbiter inState(State.Disputed)
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.