Submission Details
Severity:
Functions guaranteed to revert when called by normal users can be marked `payable`
Summary
If a function modifier such as onlyOwner, onlyBuyerOrSeller and onlyArbiter is used, the function will revert if a normal user tries to pay the function. Marking the function as payable will lower the gas cost for legitimate callers because the compiler will not include checks for whether a payment was provided.
Gas saved per Instance: ~21
Tools Used
Manual Review
Recommendations
Mrak thease functions as payable
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.