Submission Details
Severity:
Custom error has no parameters
Summary
Custom error has no parameters
Vulnerability Details
Consider adding some parameters to the error describing the cause of the error
Instances (9):
File: src/IEscrow.sol
9: error Escrow__OnlyBuyer();
10: error Escrow__OnlyBuyerOrSeller();
11: error Escrow__OnlyArbiter();
13: error Escrow__MustDeployWithTokenBalance();
15: error Escrow__DisputeRequiresArbiter();
16: error Escrow__TokenZeroAddress();
17: error Escrow__BuyerZeroAddress();
18: error Escrow__SellerZeroAddress();
Link to code - https://github.com/Cyfrin/2023-07-escrow/tree/main/src/IEscrow.sol
File: src/IEscrowFactory.sol
8: error EscrowFactory__AddressesDiffer();
Link to code - https://github.com/Cyfrin/2023-07-escrow/tree/main/src/IEscrowFactory.sol
Tools Used
Manual Code Review
Recommendations
Add parameters to the error which describe the cause
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.