Submission Details
Severity:
Move computeEscrowAddress inline
Summary
In Escrow.sol, it is cheaper to inline computeEscrowAddress than to reference it in a function. The function is pure, therefore it can be calculated off-chain for testing or UI purposes. This will decrease costs across the board.
Impact
About 100 gas can be saved in each deployment.
Tools Used
Foundry
Recommendations
Remove the computeEscrowAddress function. It is not defined within IEscrow.sol.
function newEscrow(
uint256 price,
IERC20 tokenContract,
address seller,
address arbiter,
uint256 arbiterFee,
bytes32 salt
) external returns (IEscrow) {
address computedAddress = address(uint160(uint256(keccak256(
abi.encodePacked(
bytes1(0xff),
address(this),
salt,
keccak256(
abi.encodePacked(
type(Escrow).creationCode,
abi.encode(price, tokenContract, msg.sender, seller, arbiter, arbiterFee)
)
)
)
))));
tokenContract.safeTransferFrom(msg.sender, computedAddress, price);
// ...
}
This will make two tests unusable, but the address can be calculated off-chain.
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.