Submission Details
Severity:
Redundant check for transfer success
Summary
Inside the _burnDSC method, DSCEngine contract checks for success of transferFrom call and reverts if it is false:
bool success = i_dsc.transferFrom(dscFrom, address(this), amountDscToBurn);
// This conditional is hypothtically unreachable
if (!success) {
revert DSCEngine__TransferFailed();
}
However, if the transferFrom method will not succeed, it will revert. In other case it will always return true. Therefore this check is redundant and can be removed for gas optimization.
Vulnerability Details
n/a
Impact
Unnecessary gas consumption
Tools Used
Manual review
Recommendations
Remove the success check
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.