Submission Details
Severity:
Misleading comment in DSCEngine._healthFactor
Summary
The _healthFactor method of DSCEngine contract is preceeded by the following comment:
/*
* Returns how close to liquidation a user is
* If a user goes below 1, then they can get liquidated
*/
function _healthFactor(address user) private view returns (uint256) {
(uint256 totalDscMinted, uint256 collateralValueInUsd) = _getAccountInformation(user);
return _calculateHealthFactor(totalDscMinted, collateralValueInUsd);
}
The comment implies that the minimal acceptable health factor for the user is equal to 1. This is not true - the MIN_HEALTH_FACTOR constant is equal to 1e18. Therefore this comment is misleading and in contradiction to the actual contract's logic.
Vulnerability Details
n/a
Impact
n/a
Tools Used
Manual review
Recommendations
Change the value in the comment to 1e18
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.