Submission Details
Severity:
Use constant variable instead of magic number in DSCEngine._calculateHealthFactor
Summary
In the _calculateHealthFactor method, a magic number 1e18 is used in the calculation:
return (collateralAdjustedForThreshold * 1e18) / totalDscMinted;
The best practice is to use constant variable instead of magic number for code readability.
Vulnerability Details
n/a
Impact
n/a
Tools Used
Manual review
Recommendations
Replace the magic number 1e18 with the constant variable PRECISION.
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664
USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.