Submission Details
Severity:
constants should be used rather than using magic numbers
Summary
constants should be used rather than using magic numbers
Vulnerability Details
the magic number is used , although there is a constant have the same value and the functionality PRECISION
at 2023-07-foundry-defi-stablecoin/src/DSCEngine.sol
uint256 private constant PRECISION = 1e18;
331: -> return (collateralAdjustedForThreshold * 1e18) / totalDscMinted;
Impact
decrease the readability of the contract
Tools Used
manual review
Recommendations
using PRECISION instead of 1e18
331: -> return (collateralAdjustedForThreshold * PRECISION) / totalDscMinted;
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.