Submission Details
Severity:
division before multiplication result in precision loss
Vulnerability details
division before multiplication result in precision loss
at src/DSCEngine.sol
347: -> return (usdAmountInWei * PRECISION) / (uint256(price) * ADDITIONAL_FEED_PRECISION);
Impact
division before multiplication result in precision loss which may cause loss of funds of the user,
and if the usdAmountInWei is much more bigger than price it will lead to round down to zero that will cause huge loss of funds
Recommendations
perform the multiplication first then the division
347: -> return (usdAmountInWei * PRECISION) / uint256(price) / ADDITIONAL_FEED_PRECISION);
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.