Submission Details
Severity:
Chainlink’s latestRoundData might return stale or incorrect results
Summary
Chainlink’s latestRoundData might return stale or incorrect results
Vulnerability Details
On OracleLib.sol, we are using latestRoundData, but there is not enought checks if the return value indicates stale data.
(uint80 roundId, int256 answer, uint256 startedAt, uint256 updatedAt, uint80 answeredInRound) =
priceFeed.latestRoundData();
uint256 secondsSince = block.timestamp - updatedAt;
if (secondsSince > TIMEOUT) revert OracleLib__StalePrice();
Impact
This can make the price of the token wrong/stale
Tools Used
Manual Review
Recommendations
Add more requirement
require(answeredInRound >= roundID, "Stale price");
require(answer > 0,"Chainlink price <= 0");
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.