In file DSCEngine.sol
, a hardcoded number in the code can be converted into an existing named constant for better readability.
In the line 311 of DSCEngine.sol
, contrary to the rest of the code, a number is being used directly without a named constant.
Slightly worse readability.
Notice âšī¸: I ran
forge snapshot
in the original code and the one with this "renamed" number. As expected, there is neither a gas benefit nor a drawback in its addition. The tests consumed an equivalent amount of gas.
Manual audit.
Forge snapshot.
Custom bash scripts to analyze snapshots' results.
Given that a named constant with the identical value already exists and its name is contextually relevant, it's recommended to replace the direct number with this constant:
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.