Submission Details
Severity:
Use BASIS_POINTS instead of 10000
Summary
Not using constants as intended leads to code inconsistency.
Vulnerability Details
When checking if totalPercentage equals 10000(100%) - COMMISSION_FEE we use 10000 (magic number) instead of the predefined BASIS_POINTS variable.
src/Distibutor.sol
if (totalPercentage != (10000 - COMMISSION_FEE)) {
revert Distributor__MismatchedPercentages();
}
Impact
Using magic numbers will confuse people who read the code.
Tools Used
Manual
Recommendations
if (totalPercentage != (BASIS_POINTS - COMMISSION_FEE)) {
revert Distributor__MismatchedPercentages();
}
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
19477 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.