Submission Details
Severity:
Missing event for commissionTransfer
Summary
Event is not emitted on transfer commission.
Vulnerability Details
The _commissionTransfer() in the Distributor.sol (implementation) doesn’t emit an event.
src/Distibutor.sol
function _commissionTransfer(IERC20 token) internal {
token.safeTransfer(STADIUM_ADDRESS, token.balanceOf(address(this)));
}
Impact
The person set to receive the commission or the end user may wish to receive updates about state changes.
Tools Used
Manual
Recommendations
function _commissionTransfer(IERC20 token) internal {
uint256 commissionAmount = token.balanceOf(address(this));
token.safeTransfer(STADIUM_ADDRESS, commissionAmount);
emit CommissionTransfered(STADIUM_ADDRESS, commissionAmount); // event CommissionTransfered(address stadium, uint256 amount);
}
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
19477 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.