Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Submission Details
Severity: low

Distributor Contract Audit

Summary

This audit report provides an analysis of the Distributor smart contract with regards to lower severity security vulnerabilities.

Vulnerability Details

In Distributor.sol at line 135

Vulnerability ID: M-01
Description: We are using magic numbers (10000) in the verification of totalPercentage.
Snippet:

// check if totalPercentage is correct
if (totalPercentage != (10000 - COMMISSION_FEE)) {
revert Distributor__MismatchedPercentages();
}

Recommendation

Replace the magic number (10000) with a named variable to improve code clarity and maintainability.

Impact

The use of magic numbers reduces code readability and can lead to errors during maintenance or modification of the contract.

Tools Used

Manual Review

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.