Sparkn

Summary

The protocol makes use of assembly in Proxy.sol

Vulnerability Details

Although this is not an attacker vector, it may introduce problems in the protocol as not all Solidity developers or event auditors understand assembly. Weirdly I have seen this as Low and QA in some reports.

Impact

Consider the following cases

• Developer takes over project maintenance tries to update this code to suit what they have seen elsewhere by seeing patterns and not necessarily understanding the code and so introduce errors

• Auditor not checking if this code is robust and therefore missing errors in Proxy.sol

Tools Used

Manual Analysis

Recommendations

Recommended the code be commented to explain every part of the assembly, why it is preferred, make use of Natspec