Sparkn

Summary

The COMMISSION_FEE value is currently hardcoded. Although this does not trigger any errors as it is not called, it could potentially disrupt functionality in future updates.

Vulnerability Details

The code indicates that the COMMISSION_FEE may be subject to future changes, as mentioned in the documentation for new implementations. However, a potential issue arises if the COMMISSION_FEE exceeds BASIS_POINTS.

In the code snippet:

If a new implementation is launched where COMMISSION_FEE >= BASIS_POINTS, it would cause the distribute function to revert every time. This could potentially disrupt the normal operation of the contract.

Impact

While the current implementation does not present any impact, potential future modifications, as previously discussed, could indeed have implications.

Tools Used

Manual code review

Recommendations

Incorporate a validation check within the _distribute() function to ensure that the COMMISSION_FEE is consistently less than BASIS_POINTS.