Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Submission Details
Severity: low
Valid

The variable BASIS_POINTS should be utilized to verify the accuracy of totalPercentage

Summary

The constant BASIS_POINTS is utilized but not invoked in the totalPercentage verification process.

Impact

The non-utilization of BASIS_POINTS may lead to confusion, as it can be mistaken for a different variable.

Tools Used

Manual code review

Recommendations

The BASIS_POINTS should be used.

- if (totalPercentage != (10000 - COMMISSION_FEE)) {
+ if (totalPercentage != (BASIS_POINTS - COMMISSION_FEE)) {

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.