Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Submission Details
Severity: low

The double verification for nonZeroAddress is not necessary.

Summary

The _distribute() function contains redundant verification, which is not necessary.

Vulnerability Details

Upon invocation of the _distribute() function, the initial iteration checks if token == address(0). If this condition is met, the function reverts. Subsequently, the !_isWhiteListed(token) function is called to verify if the token is whitelisted. Concurrently, within the ProxyFactory constructor, the condition _whitelistedTokens[i] == address(0).

Impact

It's rendundant.

Tools Used

Manual code review

Recommendations

Remove the verification process, and note that the condition 'token == address(0)' is not permissible.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.