Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Submission Details
Severity: low

Using Magic Numbers

Summary

Using the number 10000 as the expected total percentage.

Vulnerability Details

Using magic numbers can be unclear and potentially lead to mistakes, or unclear to people trying to understand the code.

Impact

if (totalPercentage != (10000 - COMMISSION_FEE)) { // @audit-info use of magic number
revert Distributor__MismatchedPercentages();
}

Tools Used

Manual review

Recommendations

It's better to define named constants for such values.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.