Submission Details
Severity:
Magic number is used
To improve the code’s readability and facilitate refactoring, consider using BASIS_POINTS constant instead of magic number at the Distributor._distribute function L135:
60: // a constant value of 10,000 (basis points) = 100%
61: uint256 private constant BASIS_POINTS = 10000;
...
135: if (totalPercentage != (10000 - COMMISSION_FEE)) {
https://github.com/Cyfrin/2023-08-sparkn/blob/0f139b2dc53905700dd29a01451b330f829653e9/src/Distributor.sol#L135
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
19477 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.