Submission Details
Severity:
Incorrect comment on `_canLiquidate()` natspec
Summary
It's not by 'liquidated by shorter', but, 'liquidated by flagger', shorter cannot liquidate himself.
Vulnerability Details
Incorrect comment natspect on _canLiquidate, in contracts/facets/MarginCallPrimaryFacet.sol.
Impact
Very low, but can mislead to non tech users reading the liquidate code docs.
Tools Used
Manual review.
Recommendations
Correction:
- * @dev ...After that, the flagger has 2 hours to liquidate the shorter. If short is not liquidated by shorter within that time, ANYBODY can then liquidate...`
+ * @dev ...After that, the flagger has 2 hours to liquidate the shorter. If short is not liquidated by flagger within that time, ANYBODY can then liquidate...`
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.