Summary

There is a local variable in the ISTETH interface contract called eip712Domain().name that is shadowing (hiding) another function called name() in the same interface contract.

Vulnerability Details

The ISTETH interface contract has a function called name() defined at line 9:

and it also has a function called eip712Domain() defined at line 22:

The eip712Domain() function returns a struct that contains a field called name.

Since the field name has the same name as the name() function, it is considered a local variable and it shadows the outer function.

Impact

In Solidity, shadowing occurs when a local variable or function parameter has the same name as a variable or function in an outer scope. This can lead to confusion and potential bugs because the local variable or parameter will take precedence over the outer variable or function.

Tools Used

Slither

Recommendations

Rename the name field in the eip712Domain() function to avoid the shadowing.