Submission Details
Severity:
OwnerFacet.setTithe should update yield before change
Summary
OwnerFacet.setTithe should update yield before change
Vulnerability Details
Function OwnerFacet.setTithe allows to change yields percentage that TAPP will take as fee. This means that before this can be changed, YieldFacet.updateYield should be called in order to distribute previously earned yield using old tithe and only then change to new value.
Impact
Yield will be distributed incorrectly.
Tools Used
VsCode
Recommendations
Call YieldFacet.updateYield before changing tithe.
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.