DittoETH

Ditto
DeFiFoundryOracle
55,000 USDC
View results
Submission Details
Severity: low
Invalid

Variables Shadowing

Vulnerability Details

The parent contract of Asset already contains the variable with names name and symbol and here the protocol uses the same names in the constructor.

This ambiguity confuses the compiler as to which variables the code is referring to.

This can create issues and a best practice is to avoid variable shadowing.

Tools Used

Manual Review

Recommendations

Consider the compiler warnings into consideration and avoid variable shadowing.

We can add an underscore _ prefix to the variables' names to avoid this naming confusion.

Updates

Lead Judging Commences

0xnevi Lead Judge
about 2 years ago
0xnevi Lead Judge about 2 years ago
Submission Judgement Published
Invalidated
Reason: Other

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.