DittoETH

Summary

There are events that are being emitted without any information of the new values and the old values from the changes; for critical parameter, functionality changes

Vulnerability Details

OwnerFacet.sol has a lot of setter functions that emit events that do not give information on the values especially emitting the new value and the old value. Consider below events used in most of the functions that just indicate something changed on the asset or bridge but without any information on the value changes.

The above does not give detailed information that can also help the security of the protocol

Impact

Not only does it have bad effects on user experience, offchain front ends, reporting and monitoring tools but security issues. If there is no ability to see in real time any unexpected value changes, inconsistencies this impacts the ability to react,fix etc these issues putting the protocol functionality at risk

Tools Used

Manual Analysis

Recommendations

Recommended these events also include information on the values that have been updated e.g in fashion like below

\ Change code aspects in above function to ensure new and old values emitted