DittoETH

Ditto
DeFiFoundryOracle
55,000 USDC
View results
Submission Details
Severity: low
Invalid

External calls in an un-bounded `for`-loop may result in a DOS

Summary

Using external calls in an unbounded for loop may result in a denial of service (DOS).

Vulnerability Details

There is 1 instance of this issue.

File: contracts/facets/ERC721Facet.sol
/// @audit getShortRecords() on line 30
28: for (uint256 i; i < length;) {
File Link Instance Count Instance Link
ERC721Facet.sol 1 28

Impact

Potential denial of service with a large number of assets.

Tools Used

baudit: a custom static code analysis tool; manual review

Recommendations

Consider limiting the number of iterations in for loops that make external calls.

Updates

Lead Judging Commences

0xnevi Lead Judge
about 2 years ago
0xnevi Lead Judge about 2 years ago
Submission Judgement Published
Invalidated
Reason: Out of Gas

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.