DittoETH

Vulnerability Details

M-02: Missing Zero Address Check for diamondAddr

In BridgeSteth.sol:24, there's a lack of validation for the diamondAddr parameter passed to the constructor. Specifically, there is no check to verify that diamondAddr is not the zero address.

Impact

If the zero address is accidentally set as the diamond address, it could result in loss of control over any logic or functionality that relies on the onlyDiamond modifier.

Tools Used

Manual Review

Recommendations

It is recommended to add a check that reverts the transaction if the zero address is passed as the diamondAddr parameter to the constructor.