Submission Details
Severity:
`unstakeFee` is capped at a too low percentage
Summary
unstakeFee is capped only at 2.55% which can be too low for some occasions.
Vulnerability Details
Due to s.bridge[bridge].unstakeFee being a uint8, it's max value is 255. Which when converted to percentage will be 2.55%, this may be too small at times, when the system wants to collect bigger taxes and earn more revenue.
function unstakeFee(address bridge) internal view returns (uint256) {
AppStorage storage s = appStorage();
return (uint256(s.bridge[bridge].unstakeFee) * 1 ether)
/ Constants.FOUR_DECIMAL_PLACES;
}
Impact
System may be limited on this fee.
Tools Used
Manual review
Recommendations
I would suggest to use uint16 in unstakeFee, since it will allow higher fee amount, and will not cost extra gas since there are 224 unused bits in the struct Bridge.
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.