DittoETH

Summary

There are a multiple checks missing inside the OwnerFacet, which should be implemented.

Vulnerability Details

Here is a list of missing checks inside the OwnerFacet.sol contract:

• Missing check if the vault exists inside the createMarket function

• setDittoMatchedRate and setDittoShorterRate should be checked if above 0. Otherwise, the DAO could prevent other users from becoming a part of the DAO

• Missing zero value checks in a lot of functions like for example transferAdminship

Impact

Multiple things could go wrong, like for example setting the admin accidentally to the zero address, or preventing users from joining the DAO.

Tools Used

Manual Review

Recommendations

Add all the mentioned checks.