DittoETH

Summary

The ercAmount in orders and assets is limited by their uint type. Depending on the assets / markets, which the DAO wants to add in the future, these limitations could be too small and therefore would prevent the creation of desired orders, or even the creation of specific markets at all.

Vulnerability Details

The maximum ercDebt of assets is 20.2T and the maximum ercAmount of orders is 300m. These amounts could be to small.

Impact

This could prevent users from creating their desired orders, or even need them to create a lot of small orders in comparison to the amount of assets, and therefore spam the orderbook. Also, the maximum ercAmount of an asset itself could be too small for specific markets, this could prevent the creation of the whole market, as it would not make sense to operate with these limits. This could be a big problem, if at any time in the future the DAO would like to create a market with big asset amounts.

Tools Used

Manual Review

Recommendations

Increase the uint types.