Submission Details
Severity:
redondant conditions
Summary
Vulnerability Details
in the function bidMatchAlgo() at line 208 bool dustErcAmount is define such as:
bool dustErcAmount = (lowestSell.ercAmount - incomingBid.ercAmount)
.mul(lowestSell.price) == 0;
which means if
incomingBid.ercAmount == lowestSell.ercAmount
dustErcAmount will always be true
therefore in line 211 it's useless to have this OR condition
if (dustErcAmount || incomingBid.ercAmount == lowestSell.ercAmount)
Impact
just code optimization
Tools Used
reading the code
Recommendations
replace
if (dustErcAmount || incomingBid.ercAmount == lowestSell.ercAmount)
by
if (dustErcAmount )
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.