Submission Details
Severity:
Loss of precision in TWAP price in ether
Summary
Loss of precision in baseOracleCircuitBreaker() could cause incorrect calculation price.
Vulnerability Details
There will be precision loss when calculating price, because solidity truncates values when dividing and dividing before multiplying causes precision loss.
Impact
It could cause incorrect calculation of price.
Tools Used
Manual review
Recommendations
-uint256 twapPriceInEther = (twapPrice / Constants.DECIMAL_USDC) * 1 ether; // (5 / 2) * 10) = 20
+uint256 twapPriceInEther = twapPrice * 1 ether / Constants.DECIMAL_USDC; // 5 * 10 / 2 = 25
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.