Submission Details
Severity:
[L-2] State modifying function calls should emit events
Instances(9)
FILE: FILE: 2023-09-ditto/contracts/facets/VaultFacet.sol
function depositZETH(address zeth, uint88 amount) external nonReentrant {
// ...
// + @audit should emit event e.g emit DepositedZeth();
// + emit DepositedZeth();
}
function depositAsset(address asset, uint104 amount)
external
onlyValidAsset(asset)
isNotFrozen(asset)
nonReentrant
{
// ...
// @audit should emit event e.g emit DepositedAsset();
// + emit DepositedAsset();
}
function withdrawZETH(address zeth, uint88 amount) external nonReentrant {
// ...
// @audit should emit event e.g emit WithdrawnZeth();
// + emit WithdrawnZeth();
}
function withdrawAsset(address asset, uint104 amount)
external
onlyValidAsset(asset)
nonReentrant
{
// ...
// @audit should emit event e.g emit WithdrawnAsset();
// + emit WithdrawnAsset();
}
FILE: 2023-09-ditto/contracts/facets/YieldFacet.sol
function withdrawDittoReward(uint256 vault) external nonReentrant {
// ...
// @audit should emit event e.g emit WithdrawnDittoReward();
// + emit WithdrawnDittoReward();
}
FILE: 2023-09-ditto/contracts/facets/OrdersFacet.sol
function cancelBid(address asset, uint16 id)
external
onlyValidAsset(asset)
nonReentrant
{
// ...
// @audit should emit event e.g emit CanceledBid();
// + emit CanceledBid();
}
function cancelAsk(address asset, uint16 id)
external
onlyValidAsset(asset)
nonReentrant
{
// ...
// @audit should emit event e.g emit CanceledAsk();
// + emit CanceledAsk();
}
function cancelShort(address asset, uint16 id)
external
onlyValidAsset(asset)
nonReentrant
{
// ...
// @audit should emit event e.g emit CanceledShort();
// + emit CanceledShort();
}
FILE: 2023-09-ditto/contracts/facets/ERC721Facet.sol
function mintNFT(address asset, uint8 shortRecordId)
external
isNotFrozen(asset)
nonReentrant
onlyValidShortRecord(asset, msg.sender, shortRecordId)
{
// ...
// @audit should emit event e.g emit MintedNFT();
// + emit MintedNFT();
}
Tools Used
Manual review/ VsCode
Recommendations
Emit events after change of current states
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.