Submission Details
Severity:
Unneeded type cast of contract type
Vulnerability Details
Unneeded type cast of contract type. Parameter passed to constructor is type IRocketStorage.
constructor(IRocketStorage rocketStorageAddress, address diamondAddr) {
rocketStorage = IRocketStorage(rocketStorageAddress);
diamond = diamondAddr;
// @dev (gas) use immutable instead of constant
// See https://github.com/ethereum/solidity/issues/9232#issuecomment-646131646
RETH_TYPEHASH = keccak256(
abi.encodePacked("contract.address", "rocketTokenRETH")
);
ROCKET_DEPOSIT_POOL_TYPEHASH = keccak256(
abi.encodePacked("contract.address", "rocketDepositPool")
);
}
constructor(IRocketStorage rocketStorageAddress, address diamondAddr)
rocketStorage = IRocketStorage(rocketStorageAddress);
It is assigned to rocketStorage with type casting to IRocketStorage which is unnecessary.
Tools used
VScode, Manual Review
Recommendations
Change rocketStorage = IRocketStorage(rocketStorageAddress) to rocketStorage = rocketStorageAddress
or change IRocketStorage rocketStorageAddress to address rocketStorageAddress
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.