DittoETH
Ditto
DeFiFoundryOracle
55,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Unneeded type cast of contract type

ke1cam

Vulnerability Details

Unneeded type cast of contract type. Parameter passed to constructor is type IRocketStorage.

constructor(IRocketStorage rocketStorageAddress, address diamondAddr) {
rocketStorage = IRocketStorage(rocketStorageAddress);
diamond = diamondAddr;
// @dev (gas) use immutable instead of constant
// See https://github.com/ethereum/solidity/issues/9232#issuecomment-646131646
RETH_TYPEHASH = keccak256(
abi.encodePacked("contract.address", "rocketTokenRETH")
);
ROCKET_DEPOSIT_POOL_TYPEHASH = keccak256(
abi.encodePacked("contract.address", "rocketDepositPool")
);
}
constructor(IRocketStorage rocketStorageAddress, address diamondAddr)
rocketStorage = IRocketStorage(rocketStorageAddress);

It is assigned to rocketStorage with type casting to IRocketStorage which is unnecessary.

Tools used

VScode, Manual Review

Recommendations

Change rocketStorage = IRocketStorage(rocketStorageAddress) to rocketStorage = rocketStorageAddress

or change IRocketStorage rocketStorageAddress to address rocketStorageAddress

Updates

Lead Judging Commences

0xnevi Lead Judge
almost 2 years ago
0xnevi Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Gas optimizations

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.