DittoETH
Ditto
DeFiFoundryOracle
55,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Event Emission Preceding External Calls Best Practice to Prevent Reentrancy

David77

Event Emission Preceding External Calls Best Practice to Prevent Reentrancy

  • Severity: LOW

  • Confidence: Medium

Description

Ensure that events follow the best practice of check-effects-interaction, and are emitted before external calls

There are 1 instances of this issue:

Reentrancy in

File: contracts/facets/BridgeRouterFacet.sol
​
142 function withdrawTapp(address bridge, uint88 zethAmount)
143 external
144 onlyDAO
145 onlyValidBridge(bridge)
146

:
External calls:
-

File: contracts/facets/BridgeRouterFacet.sol
​
160 IBridge(bridge).withdraw(msg.sender, ethAmount)
Event emitted after the call(s):
-
File: contracts/facets/BridgeRouterFacet.sol
​
161 emit Events.WithdrawTapp(bridge, msg.sender, zethAmount)

https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/facets/BridgeRouterFacet.sol#L142-L162

Updates

Lead Judging Commences

0xnevi Lead Judge
almost 2 years ago
0xnevi Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Other

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.