DittoETH

Summary

The combined short record might exceed the maximum collateral ratio (CRATIO_MAX).

Vulnerability Details

The collateral of a short record can be increased in two distinct manners:

1. Boosting collateral (Refer to ShortRecordFacet#increaseCollateral)

2. Merging short records (Refer to ShortRecordFacet#combineShorts)

While there's a cap in place for CR in the first method, ensuring it doesn't surpass CRATIO_MAX, the same restriction is absent in the second method.

Impact

A short record formed via the merging of other short records might result in a CR that surpasses the CRATIO_MAX limit.

Tools Used

Manual

Recommendations

Add the subsequent validation to ShortRecordFacet#combineShorts