DittoETH
Ditto
DeFiFoundryOracle
55,000 USDC
View results
Previous Next
Submission Details
Severity: medium
Invalid

Missing upper bound check for reth

Bauer

Summary

The functionality to deposit ETH and mint rETH will become unavailable.

Vulnerability Details

The BridgeRouterFacet.depositEth() function enables users to deposit ETH into the protocol. Within the function, the protocol deposits ETH into the rocketDepositPool to acquire reth.
This current functionality is problematic for the rETH because there is an upper bound set by the Rocket Pool Protocol's DOA for the amount a user can deposit to a pool at once. This upper bound is currently equal to 18000 ETH.
And per Rocket Pool's RocketDepositPool contract, there is an other check to confirm the availability of the intended deposit.

​
require(rocketDAOProtocolSettingsDeposit.getDepositEnabled(), "Deposits into Rocket Pool are currently disabled");
​

Impact

The functionality to deposit ETH and mint rETH will become unavailable.

Tools Used

Vscode

Recommendations

For Reth contract; Checking the Rocket Pool's RocketDAOProtocolSettingsDeposit.getMaximumDepositPoolSize()

Updates

Lead Judging Commences

0xnevi Lead Judge
almost 2 years ago
0xnevi Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Other

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.