Incorrect check for cRation_MAX
Summary
The current implementation of the check stops the user for increasing the collateral with the exact max amount.
Vulnerability Details
However this is not a problem and funds are not at risk, it may be confusing for the user, the error he is going to see states that the amount sent by him is higher than the maximum, as it will still revert if it is equal to the maximum.
Impact
Tools Used
Manual Review
Recommendations
Change this code:
if (cRatio >= Constants.CRATIO_MAX) revert Errors.CollateralHigherThanMax();
to this code
if (cRatio > Constants.CRATIO_MAX) revert Errors.CollateralHigherThanMax();
or implement a better error message if this is the intended behavior.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.