Submission Details
Severity:
Potential Reentrancy on Short Record Updates
Summary
Updating short records via fillShortRecord() can be vulnerable to reentrancy.
Vulnerability Details
fillShortRecord() calls external contracts for yield rates. If these contracts are malicious, they could reenter fillShortRecord() before state is updated.
For example:
function fillShortRecord(
// ...
) external {
// Interaction
assetYieldRate = s.asset[asset].zethYieldRate;
// State changes
short.collateral += eth;
// Vulnerable to reentrancy here
}
Impact
Reentrancy could lead to collateral being drained or unexpected state changes.
Tools Used
Manual
Recommendations
Use checks-effects-interactions pattern
Add reentrancy guard
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.