Submission Details
Severity:
Unsafe downcast
Summary
Unsafe downcast
Vulnerability Details
When a type is downcast to a smaller type, the higher-order bits are truncated, effectively applying a modulo to the original value. Without any other checks, this wrapping will lead to unexpected behavior and bugs
File: contracts/facets/OwnerFacet.sol
//@audit `vault` is getting converted from `uint256` to `uint8`
281: s.bridge[bridge].vault = uint8(vault);
File: contracts/libraries/LibOracle.sol
//@audit `oraclePrice` is getting converted from `uint256` to `uint80`
136: s.bids[asset][Constants.HEAD].ercAmount = uint80(oraclePrice);
Impact
Possible overflows
Tools Used
Manual
Recommendations
Check the values before/after performing the cast
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.