Submission Details
Severity:
ExitShortFacet Not updating ethEscrowed
Summary
on exitShort function call Temporary accounting to enable bid to add collateral to ethEscrowed but after createForcedBid, the value will not restore when Refund the rest of the collateral if ercDebt is fully paid back
Vulnerability Details
Incorrect VaultUser.ethEscrowed
// Refund the rest of the collateral if ercDebt is fully paid back
if (e.ercDebt == e.ercFilled) {
// Full Exit
//@audit-info check why this one not reduce here
// VaultUser.ethEscrowed -= e.collateral - e.ethFilled;
LibShortRecord.disburseCollateral(
e.asset, msg.sender, e.collateral, short.zethYieldRate, short.updatedAt
);
LibShortRecord.deleteShortRecord(e.asset, msg.sender, id); // prevent re-entrancy
}
Impact
have extra ethEscrowed which should not be their
Tools Used
Manual code Review
Recommendations
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.