Submission Details
Severity:
Consider using descriptive `constant`s when passing zero as a function argument
Summary
Consider using descriptive constants when passing zero as a function argument
Vulnerability Details
Passing zero as a function argument can sometimes result in a security issue (e.g. passing zero as the slippage parameter).
File: contracts/facets/OwnerFacet.sol
//@audit parameter number 4 starting from left
91: LibShortRecord.createShortRecord(
asset, address(this), SR.FullyFilled, 0, 0, 0, 0, 0
);
//@audit parameter number 5 starting from left
91: LibShortRecord.createShortRecord(
asset, address(this), SR.FullyFilled, 0, 0, 0, 0, 0
);
//@audit parameter number 6 starting from left
91: LibShortRecord.createShortRecord(
asset, address(this), SR.FullyFilled, 0, 0, 0, 0, 0
);
//@audit parameter number 7 starting from left
91: LibShortRecord.createShortRecord(
asset, address(this), SR.FullyFilled, 0, 0, 0, 0, 0
);
Impact
Tools Used
Manual
Recommendations
Consider using a constant variable with a descriptive name, so it's clear that the argument is intentionally being used, and for the right reasons.
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.