Submission Details
Severity:
liquidate TAPP.ethEscrowed will unchanged
Summary
TAPP.ethEscrowed and Total feed will be zero in case, while liquidate when we createForcedBid no match found bidorder:152, then it will return ethFilled = 0 MarginCallPrimaryFacet :239 which will be multiple with other values make the zero
Vulnerability Details
on
_marginFeeHandler
uint88 tappFee = m.ethFilled.mulU88(m.tappFeePct);
uint88 callerFee = m.ethFilled.mulU88(m.callerFeePct) + m.gasFee;
// VaultUser.ethEscrowed will be also zero
VaultUser.ethEscrowed += callerFee - m.gasFee + tappFee;
// totalFee and TAPP.ethEscrowed also be zero
m.totalFee -= m.gasFee;
TAPP.ethEscrowed -= m.totalFee;
on _fullorPartialLiquidation
// L274 ethFilled was zero then totalFee contain only gasfee which make it zero
// make it zero multiply make it decreaseCol zero
uint88 decreaseCol = min88(m.totalFee + m.ethFilled, m.short.collateral);
Impact
TotalFee will be zero and TAPP.ethEscrowed will be unchange
Tools Used
Manual code Dry run.
Recommendations
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.