DittoETH

Ditto
DeFiFoundryOracle
55,000 USDC
View results
Submission Details
Severity: low
Invalid

_distributeYield initialCR add additional 1 Ether YieldFacet

Summary

_distributeYield when get the initialCR it already multiple or convert into Ether 18 decimal by LibAsset.initialMargin(asset) why need to add one more extra ether without any explanations.

Vulnerability Details

//L89 when we get the initialMargin it was 5eth and one more mean make it 6 eth
uint256 initialCR = LibAsset.initialMargin(asset) + 1 ether;

what is purpose of this action

Impact

lead to incorrect results

Tools Used

Code Reivew.

Recommendations

Updates

Lead Judging Commences

0xnevi Lead Judge
almost 2 years ago
0xnevi Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Vague generalities

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.