Submission Details
Severity:
Division before multiplication causing significant loss of precision
Summary
First divides and then multiplies again, there is a significant loss of precision;
Vulnerability Details
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/libraries/LibOracle.sol#L85
uint256 twapPriceInEther = (twapPrice / Constants.DECIMAL_USDC) * 1 ether;
Tools Used
Manual Review
Recommendations
Multiply first before dividing to keep the precision.
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.