DittoETH

Summary-medium

Owner can be deceived to send funds to a malicious contract leading to re-entrancy.

Vulnerability Details

Malicious contract can reenter the contract that will lead to access to transfer function and can manipulate project funds.

Impact

A user can create a malicious attack and sent Eth using the malicious contract for staking.
After sometime the malicious actor withdraw its Eth from the project which bound administrator to transfer the eth back to the malicious actor using transfer function in line 94.

The administrator can unknowingly interact with the malicious account while executing the transfer function as an external call to send rocketETHToken that can lead to possible re-entrancy attack.

Tools Used

Manual Code Review

Recommendations

Use nonreentrancy guard modifier that will prevent any re-entrancy into the withdraw function.
Add OpenZepplin nonReentrant modifier on withdraw() function at line 85 in BridgeReth.sol